caibirdme / yql

yet another query language for rule engine in golang
MIT License
309 stars 52 forks source link

Consider migrating to "github.com/antlr/antlr4/runtime/Go/antlr/v4" #13

Open Rick-xuy opened 1 year ago

Rick-xuy commented 1 year ago

It seems that v1 module of github.com/antlr/antlr4/runtime/Go/antlr has been deprecated.
https://github.com/antlr/antlr4/blob/master/runtime/Go/antlr/go.mod

// Deprecated: Please switch to the new v4 module path: github.com/antlr/antlr4/runtime/Go/antlr/v4 - see https://github.com/antlr/antlr4/blob/master/doc/go-target.md
module github.com/antlr/antlr4/runtime/Go/antlr

The new module is github.com/antlr/antlr4/runtime/Go/antlr/v4 and it fit more properly with the idiomatic ways of Go than v1 module. For example, migrating to v4 may reduce the likehood of ambiguous import error related to antlr.
Is there any plan to migrate to github.com/antlr/antlr4/runtime/Go/antlr/v4? If so, this doc may help.

caibirdme commented 1 year ago

If there's no breaking changes or just a few changes, I'm willing to do that

Rick-xuy commented 1 year ago

Ok, I see. Thanks for your feedback!