search

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

*: Add first version of the code #1

Closed gaocegege closed 6 years ago

gaocegege commented 6 years ago

/assign @ddysher 

NONE
gaocegege commented 6 years ago

For these suggestions about improvements, I have opened some issues to keep track. And I will address other comments today or tomorrow.

gaocegege commented 6 years ago

@ddysher Addressed, PTAL

ddysher commented 6 years ago

Thanks! btw, can u add vendor?

/lgtm

caicloud-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ddysher To fully approve this pull request, please assign additional approvers. We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ddysher commented 6 years ago

First PR without OWNERS file, manually merge.