cmd: Use cobra to support configuration

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook

Apache License 2.0

67 stars 18 forks source link

cmd: Use cobra to support configuration #22

Closed gaocegege closed 6 years ago

gaocegege commented 6 years ago

What this PR does / why we need it:

Add cobra to support config of the kubeconfig

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #21 #14

Reference to #

Special notes for your reviewer:

/cc @ddysher

Release note:

NONE

gaocegege commented 6 years ago

/assign @ddysher

gaocegege commented 6 years ago

Updated

/assign @ddysher

gaocegege commented 6 years ago

The config is placed in $HOME/.ciao, PTAL @ddysher

gaocegege commented 6 years ago

Fixed, PTAL

@ddysher

ddysher commented 6 years ago

one last comment, i'll merge to proceed. /lgtm

gaocegege commented 6 years ago

PTAL @ddysher

/approve

ddysher commented 6 years ago

/lgtm

caicloud-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddysher, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [ddysher,gaocegege] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment