search

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

img: Add login #39

Closed gaocegege closed 6 years ago

gaocegege commented 6 years ago

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Add login to push images to a docker registry.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #38

Special notes for your reviewer:

/cc @ddysher

Release note:

NONE
ddysher commented 6 years ago

/lgtm

caicloud-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddysher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [ddysher] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment