pkg: Support using configmap to store the code

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook

Apache License 2.0

67 stars 18 forks source link

pkg: Support using configmap to store the code #43

Closed gaocegege closed 6 years ago

gaocegege commented 6 years ago

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Use configmap to place to code in order to speedup.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #41

Release note:

NONE

gaocegege commented 6 years ago

/assign @ddysher

Now the overhead imported from kubernetes is reduced to ~5s

gaocegege commented 6 years ago

@ddysher

PTAL if you have time.

ddysher commented 6 years ago

Thanks!

/lgtm

caicloud-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddysher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [ddysher] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment