search

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

[refactor] Separate CM and image in s2i #46

Open gaocegege opened 6 years ago

gaocegege commented 6 years ago

Ref #https://github.com/caicloud/ciao/pull/43#discussion_r221487888

Is it still correct to say s2i now that with configmap, we don't really build an image.

I can live with this if we think the image in s2i means the pre-defined image + code, but considering what the s2i project doest (actually building an image), this can be a little confusing.

gaocegege commented 6 years ago

/kind enhancement

caicloud-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

/lifecycle stale

gaocegege commented 5 years ago

/priority p1