search

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

*: Add copyright header #48

Closed gaocegege closed 6 years ago

gaocegege commented 6 years ago

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Add copyright

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #23

Special notes for your reviewer:

/cc @ddysher

Release note:

NONE
coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 25

Totals Coverage Status
Change from base Build 23: -25.8%
Covered Lines: 317
Relevant Lines: 663
💛 - Coveralls
ddysher commented 6 years ago

-26% coverage drop?

gaocegege commented 6 years ago

The coveralls is 抽风的, the actual coverage of the project should be 48%. Sometimes coveralls will tell us the coverage is 97%. I am not sure whether goveralls or coveralls.io has the bug.

ddysher commented 6 years ago

ok...

The coveralls is 抽风的, the actual coverage of the project should be 48%. Sometimes coveralls will tell us the coverage is 97%. I am not sure whether goveralls or coveralls.io has the bug.

/lgtm

I think the robot won't merge it since the status is red?

caicloud-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddysher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [ddysher] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ddysher commented 6 years ago

I'll force merge since there seems to be some problems with coverall.