configmap: Add unit test cases

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook

Apache License 2.0

67 stars 18 forks source link

configmap: Add unit test cases #50

Closed gaocegege closed 6 years ago

gaocegege commented 6 years ago

What this PR does / why we need it:

Added unit test for configmap s2i client.

Special notes for your reviewer:

/assign @ddysher

Release note:

NONE

gaocegege commented 6 years ago

Only https://github.com/caicloud/ciao/pull/50/commits/f2104b4ceeb8c9a998da12ff7223dd3d4380f4b3 needs to be reviewed. The other commit is to update the vendor.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 27

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.1%) to 49.925%

Totals
Change from base Build 26:	2.1%
Covered Lines:	331
Relevant Lines:	663

💛 - Coveralls

ddysher commented 6 years ago

/lgtm

caicloud-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddysher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [ddysher] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment