search

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

[feature] Cleanup after job is finished #54

Closed gaocegege closed 5 years ago

gaocegege commented 6 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Delete all resources when a job is finished.

gaocegege commented 5 years ago

/priority p1

gaocegege commented 5 years ago

I think we should have a flag to control the behavior. Maybe there are some users who want to keep the resource.

gaocegege commented 5 years ago

Kubeflow tfjob/pytorchjob now suports clean policy, thus we could just reuse it. Maybe we should add a new magic command to control the behavior. For exmaple

% cleanpolicy=All/Running/None
yeya24 commented 5 years ago

@gaocegege I' d like to take this. Look like not quite difficult for me. :smile:

gaocegege commented 5 years ago

@yeya24 I'd appreciate it if you could take this. Feel free to contact with me if you meet any question during the development!

/assign @yeya24

(Maybe you cannot be assigned since you are not in the org, but it does not matter.)

caicloud-bot commented 5 years ago

@gaocegege: GitHub didn't allow me to assign the following users: yeya24.

Note that only caicloud members and repo collaborators can be assigned.

In response to [this](https://github.com/caicloud/ciao/issues/54#issuecomment-483158120): >@yeya24 I'd appreciate it if you could take this. Feel free to contact with me if you meet any question during the development! > >/assign @yeya24 > >(Maybe you cannot be assigned since you are not in the org, but it does not matter.) Instructions for interacting with me using PR comments are available [here](https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.