caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

README: Add gif demo #56

Closed gaocegege closed 5 years ago

gaocegege commented 6 years ago

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Add demo in README

Special notes for your reviewer:

/cc @ddysher

Release note:

NONE
caicloud-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: gaocegege

Assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 35


Files with Coverage Reduction New Missed Lines %
pkg/s2i/configmap/configmap.go 14 63.64%
<!-- Total: 14 -->
Totals Coverage Status
Change from base Build 34: -42.7%
Covered Lines: 331
Relevant Lines: 663

💛 - Coveralls
ddysher commented 6 years ago

hmm, same old problem with coverall?

gaocegege commented 6 years ago

Yeah...

gaocegege commented 5 years ago

/assign @ddysher

ddysher commented 5 years ago

manually merge