Closed gaocegege closed 5 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: gaocegege
Assign the PR to them by writing /assign @gaocegege
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/s2i/configmap/configmap.go | 14 | 63.64% | ||
<!-- | Total: | 14 | --> |
Totals | |
---|---|
Change from base Build 34: | -42.7% |
Covered Lines: | 331 |
Relevant Lines: | 663 |
hmm, same old problem with coverall?
Yeah...
/assign @ddysher
manually merge
Signed-off-by: Ce Gao gaoce@caicloud.io
What this PR does / why we need it:
Add demo in README
Special notes for your reviewer:
/cc @ddysher
Release note: