Closed gaocegege closed 5 years ago
Hey @gaocegege, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/backend/kubeflow/pytorchjob.go | 0 | 1 | 0.0% | ||
pkg/backend/kubeflow/tfjob.go | 0 | 1 | 0.0% | ||
pkg/s2i/configmap/configmap.go | 2 | 4 | 50.0% | ||
pkg/backend/kubeflow/kubeflow.go | 0 | 9 | 0.0% | ||
<!-- | Total: | 14 | 27 | 51.85% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/s2i/configmap/configmap.go | 1 | 60.87% | ||
pkg/backend/kubeflow/kubeflow.go | 2 | 0.0% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 36: | 0.08% |
Covered Lines: | 335 |
Relevant Lines: | 670 |
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ddysher
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Signed-off-by: Ce Gao gaoce@caicloud.io
What this PR does / why we need it:
Added config field
namespace
to support customized namespace.Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #45
Special notes for your reviewer:
/cc @ddysher
Release note: