caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

*: Support customized namespace #59

Closed gaocegege closed 5 years ago

gaocegege commented 5 years ago

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Added config field namespace to support customized namespace.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #45

Special notes for your reviewer:

/cc @ddysher

Release note:

NONE
TravisBuddy commented 5 years ago

Travis tests have failed

Hey @gaocegege, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

View build log

gometalinter --config=linter_config.json --vendor ./... ``` pkg/backend/kubeflow/generator/cm_test.go:27:14:warning: too few arguments in call to NewCM (gosimple, staticcheck) pkg/backend/kubeflow/generator/cm_test.go:27:14:warning: unused variable or constant too few arguments in call to NewCM (varcheck) pkg/backend/kubeflow/generator/cm_test.go:55:14:warning: unused variable or constant too few arguments in call to NewCM (varcheck) pkg/backend/kubeflow/generator/native_test.go:27:18:warning: unused variable or constant too few arguments in call to NewNative (varcheck) pkg/backend/kubeflow/generator/native_test.go:55:18:warning: unused variable or constant too few arguments in call to NewNative (varcheck) ```
goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/kernel/*.go" ``` ? github.com/caicloud/ciao/pkg/backend [no test files] ? github.com/caicloud/ciao/pkg/backend/kubeflow [no test files] FAIL github.com/caicloud/ciao/pkg/backend/kubeflow/generator [build failed] exit status 2: warning: no packages being tested depend on github.com/caicloud/ciao/pkg/backend warning: no packages being tested depend on github.com/caicloud/ciao/pkg/backend/kubeflow warning: no packages being tested depend on github.com/caicloud/ciao/pkg/config warning: no packages being tested depend on github.com/caicloud/ciao/pkg/interpreter warning: no packages being tested depend on github.com/caicloud/ciao/pkg/interpreter/simple warning: no packages being tested depend on github.com/caicloud/ciao/pkg/kernel warning: no packages being tested depend on github.com/caicloud/ciao/pkg/manager warning: no packages being tested depend on github.com/caicloud/ciao/pkg/s2i warning: no packages being tested depend on github.com/caicloud/ciao/pkg/s2i/img warning: no packages being tested depend on github.com/caicloud/ciao/pkg/s2i/mock warning: no packages being tested depend on github.com/caicloud/ciao/pkg/s2i/simple # github.com/caicloud/ciao/pkg/backend/kubeflow/generator pkg/backend/kubeflow/generator/cm_test.go:27:13: not enough arguments in call to NewCM have () want (string) pkg/backend/kubeflow/generator/cm_test.go:55:13: not enough arguments in call to NewCM have () want (string) pkg/backend/kubeflow/generator/native_test.go:27:17: not enough arguments in call to NewNative have () want (string) pkg/backend/kubeflow/generator/native_test.go:55:17: not enough arguments in call to NewNative have () want (string) ```

3rd Build

View build log

gometalinter --config=linter_config.json --vendor ./... ``` pkg/backend/kubeflow/generator/cm_test.go:27:13:error: not enough arguments in call to NewCM (vet) pkg/backend/kubeflow/generator/native_test.go:27:17:error: not enough arguments in call to NewNative (vet) pkg/backend/kubeflow/generator/cm_test.go:55:14:warning: unused variable or constant too few arguments in call to NewCM (varcheck) pkg/backend/kubeflow/generator/cm_test.go:27:14:warning: too few arguments in call to NewCM (gosimple, staticcheck) pkg/backend/kubeflow/generator/cm_test.go:55:13:error: not enough arguments in call to NewCM (vet) pkg/backend/kubeflow/generator/native_test.go:55:17:error: not enough arguments in call to NewNative (vet) pkg/backend/kubeflow/generator/cm_test.go:27:14:warning: unused variable or constant too few arguments in call to NewCM (varcheck) pkg/backend/kubeflow/generator/native_test.go:27:18:warning: unused variable or constant too few arguments in call to NewNative (varcheck) pkg/backend/kubeflow/generator/native_test.go:55:18:warning: unused variable or constant too few arguments in call to NewNative (varcheck) ```
goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/kernel/*.go" ``` ? github.com/caicloud/ciao/pkg/backend [no test files] ? github.com/caicloud/ciao/pkg/backend/kubeflow [no test files] FAIL github.com/caicloud/ciao/pkg/backend/kubeflow/generator [build failed] exit status 2: warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/backend warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/backend/kubeflow warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/config warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/interpreter warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/interpreter/simple warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/kernel warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/manager warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/s2i warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/s2i/img warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/s2i/mock warning: no packages being tested depend on matches for pattern github.com/caicloud/ciao/pkg/s2i/simple # github.com/caicloud/ciao/pkg/backend/kubeflow/generator pkg/backend/kubeflow/generator/cm_test.go:27:13: not enough arguments in call to NewCM have () want (string) pkg/backend/kubeflow/generator/cm_test.go:55:13: not enough arguments in call to NewCM have () want (string) pkg/backend/kubeflow/generator/native_test.go:27:17: not enough arguments in call to NewNative have () want (string) pkg/backend/kubeflow/generator/native_test.go:55:17: not enough arguments in call to NewNative have () want (string) ```
TravisBuddy Request Identifier: 904d5540-df13-11e8-897b-d3040ed8e62f
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 38


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/backend/kubeflow/pytorchjob.go 0 1 0.0%
pkg/backend/kubeflow/tfjob.go 0 1 0.0%
pkg/s2i/configmap/configmap.go 2 4 50.0%
pkg/backend/kubeflow/kubeflow.go 0 9 0.0%
<!-- Total: 14 27 51.85% -->
Files with Coverage Reduction New Missed Lines %
pkg/s2i/configmap/configmap.go 1 60.87%
pkg/backend/kubeflow/kubeflow.go 2 0.0%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 36: 0.08%
Covered Lines: 335
Relevant Lines: 670

💛 - Coveralls
ddysher commented 5 years ago

/lgtm

caicloud-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddysher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [ddysher] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment