caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

update tfjob and pytorchjob to v1beta2 #65

Closed yeya24 closed 5 years ago

yeya24 commented 5 years ago

What this PR does / why we need it:

Update TFJob/PyTorchJob to v1beta2

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #64

Special notes for your reviewer:

/cc @gaocegege

Release note:

Update TFJob/PyTorchJob to v1beta2
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 47


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/backend/kubeflow/pytorchjob.go 0 1 0.0%
pkg/backend/kubeflow/tfjob.go 0 1 0.0%
<!-- Total: 32 34 94.12% -->
Totals Coverage Status
Change from base Build 46: 0.0%
Covered Lines: 352
Relevant Lines: 687

💛 - Coveralls
gaocegege commented 5 years ago

/lgtm /approve

caicloud-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [gaocegege] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment