search

caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

fix: Fix the errors in Docker build #69

Closed gaocegege closed 5 years ago

gaocegege commented 5 years ago

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Add your description

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #68

Reference to #

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE
gaocegege commented 5 years ago

/cc @chengyumeng

/assign @ddysher

caicloud-bot commented 5 years ago

@gaocegege: GitHub didn't allow me to request PR reviews from the following users: chengyumeng.

Note that only caicloud members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/caicloud/ciao/pull/69#issuecomment-508614472): >/cc @chengyumeng > >/assign @ddysher Instructions for interacting with me using PR comments are available [here](https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 54

Totals Coverage Status
Change from base Build 53: 0.0%
Covered Lines: 450
Relevant Lines: 816
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 54

Totals Coverage Status
Change from base Build 53: 0.0%
Covered Lines: 450
Relevant Lines: 816
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 54

Totals Coverage Status
Change from base Build 53: 0.0%
Covered Lines: 450
Relevant Lines: 816
💛 - Coveralls
ddysher commented 5 years ago

/lgtm

caicloud-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddysher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [ddysher] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment