caicloud / ciao

Kernel for Kubeflow in Jupyter Notebook
Apache License 2.0
67 stars 18 forks source link

fix: kernel start failed when kubeconfig is unset #82

Closed minshenglin closed 5 years ago

minshenglin commented 5 years ago

What this PR does / why we need it:

add KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT to env whitelist so kubeflow kernel can inherit those variables from kernel gateway.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #81

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 73


Totals Coverage Status
Change from base Build 72: 0.0%
Covered Lines: 357
Relevant Lines: 408

💛 - Coveralls
gaocegege commented 5 years ago

/lgtm /approve

Thanks for your contribution! :tada: :+1: It is a known bug in the kernel

caicloud-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/ciao/blob/master/OWNERS)~~ [gaocegege] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment