search

caicloud / cyclone

Powerful workflow engine and end-to-end pipeline solutions implemented with native Kubernetes resources. https://cyclone.dev
Apache License 2.0
1.07k stars 168 forks source link

cps-2.8: feat(controllers): make resyncPeriod configurable #1520

Closed knight42 closed 3 years ago

knight42 commented 3 years ago

What this PR does / why we need it:

Make resyncPeriod configurable

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Release note:

NONE
caicloud-bot commented 3 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to finish a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://github.com/caicloud/engineering/blob/master/guidelines/cla.md to complete the CLA.

Instructions for interacting with me using PR comments are available [here](https://github.com/caicloud/engineering/blob/master/guidelines/caicloud_bot.md). If you have questions or suggestions related to my behavior, please file an issue against the [caicloud/tools](https://github.com/caicloud/tools/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/caicloud/engineering/blob/master/guidelines/caicloud_bot.md#bot-commands).
caicloud-bot commented 3 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to finish a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://github.com/caicloud/engineering/blob/master/guidelines/cla.md to complete the CLA.

Instructions for interacting with me using PR comments are available [here](https://github.com/caicloud/engineering/blob/master/guidelines/caicloud_bot.md). If you have questions or suggestions related to my behavior, please file an issue against the [caicloud/tools](https://github.com/caicloud/tools/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/caicloud/engineering/blob/master/guidelines/caicloud_bot.md#bot-commands).
zhujian7 commented 3 years ago

/lgtm

caicloud-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/cyclone/blob/master/OWNERS)~~ [zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment