Refactor: change wfr spec and Reconcile method

caicloud / cyclone

Powerful workflow engine and end-to-end pipeline solutions implemented with native Kubernetes resources. https://cyclone.dev

Apache License 2.0

1.07k stars 168 forks source link

Refactor: change wfr spec and Reconcile method #1527

Closed knight42 closed 3 years ago

knight42 commented 3 years ago

What type of PR is this?

/kind cleanup /area cicd

What this PR does / why we need it:

Update some field names in WorkflowRun spec to make them less ambiguous
Change the Reconcile() method to return the result to allow more fine-grained control of requeuing

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Does this PR introduce a user-facing change?:

NONE

zhujian7 commented 3 years ago

/remove-kind api-change

zhujian7 commented 3 years ago

/lgtm

caicloud-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/cyclone/blob/master/OWNERS)~~ [zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment