Modify helm chart - Githubissues

caicloud / cyclone

Powerful workflow engine and end-to-end pipeline solutions implemented with native Kubernetes resources. https://cyclone.dev

Apache License 2.0

1.07k stars 168 forks source link

Modify helm chart #1534

Closed knight42 closed 3 years ago

knight42 commented 3 years ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Move the original templates to templates/
Move the original helm chart to manifests/cyclone-public
Add a new helm chart to manifests/cyclone

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Does this PR introduce a user-facing change?:

NONE

knight42 commented 3 years ago

/hold

need to create a dedicated service account and grant appropriate privileges

zhujian7 commented 3 years ago

/LGTM

zhujian7 commented 3 years ago

/HOLD CANCEL

caicloud-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/cyclone/blob/master/OWNERS)~~ [zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zhujian7 commented 3 years ago

/hold cancel