search

caicloud / cyclone

Powerful workflow engine and end-to-end pipeline solutions implemented with native Kubernetes resources. https://cyclone.dev
Apache License 2.0
1.07k stars 168 forks source link

Ensure workflowRun controller return immediately after updating #1562

Closed knight42 closed 3 years ago

knight42 commented 3 years ago

What type of PR is this?

/area cicd /kind bug

What this PR does / why we need it:

Currently a workflowRun could be updated 3 times during reconciliation, which causes subtle bug, for instance the operator begins to reconcile before receiving the 3rd update from the API server.

This PR makes sure the workflowRun controller return immediately after updating the workflowRun object.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Does this PR introduce a user-facing change?:

fix: ensure workflowRun controller return immediately after updating
zhujian7 commented 3 years ago

/lgtm

caicloud-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/cyclone/blob/master/OWNERS)~~ [zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment