search

caicloud / cyclone

Powerful workflow engine and end-to-end pipeline solutions implemented with native Kubernetes resources. https://cyclone.dev
Apache License 2.0
1.07k stars 168 forks source link

fix(github): use BasicAuthTransport #1564

Closed knight42 closed 3 years ago

knight42 commented 3 years ago

What type of PR is this?

/area cicd /kind bug

What this PR does / why we need it:

Switch to github.BasicAuthTransport to avoid 401 response from github.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Does this PR introduce a user-facing change?:

fix(github): use BasicAuthTransport
zhujian7 commented 3 years ago

/lgtm

caicloud-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/cyclone/blob/master/OWNERS)~~ [zhujian7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knight42 commented 3 years ago

/cherrypick cps-2.10

caicloud-bot commented 3 years ago

@knight42: once the present PR merges, I will cherry-pick it on top of cps-2.10 in a new PR and assign it to you.

In response to [this](https://github.com/caicloud/cyclone/pull/1564#issuecomment-768770712): >/cherrypick cps-2.10 Instructions for interacting with me using PR comments are available [here](https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
caicloud-bot commented 3 years ago

@knight42: new pull request created: #1565

In response to [this](https://github.com/caicloud/cyclone/pull/1564#issuecomment-768770712): >/cherrypick cps-2.10 Instructions for interacting with me using PR comments are available [here](https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.