fix(wfr): calculate overall status of wfr correctly

caicloud / cyclone

Powerful workflow engine and end-to-end pipeline solutions implemented with native Kubernetes resources. https://cyclone.dev

Apache License 2.0

1.07k stars 168 forks source link

fix(wfr): calculate overall status of wfr correctly #1571

Closed knight42 closed 3 years ago

knight42 commented 3 years ago

What type of PR is this?

/area cicd /kind bug

What this PR does / why we need it: Currently if a stage is trivial and fails because of failing to create pod, the controller would still consider it as succeeded. This PR fix this behavior.

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Does this PR introduce a user-facing change?:

NONE

caicloud-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: supereagle

Assign the PR to them by writing /assign @supereagle in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/caicloud/cyclone/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment