search

caicloud / nirvana

Golang Restful API Framework for Productivity
https://caicloud.github.io/nirvana/
Apache License 2.0
517 stars 106 forks source link

client: Add pkg/modifiers to default read paths #459

Closed caitong93 closed 3 years ago

caitong93 commented 3 years ago

Signed-off-by: Tong Cai caitong93@gmail.com

What this PR does / why we need it:

Now client generation in the guide it broken.

Reproduce:

$ nirvana init test-server
$ cd test-server
$ nirvana client
INFO  0430-12:51:29.656+08 client.go:75 | No packages are specified, defaults to pkg/apis
FATAL 0430-12:51:32.290+08 main.go:28 | definitions of path /apis/v1/messages: func=test-server/pkg/handlers.ListMessages: the number of parameters and function args are not equal: len(params)=1, len(funcArgs)=2
exit status 1
FATAL 0430-12:51:32.296+08 client.go:46 | exit status 1

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @iawia002 @kdada

Release note:

NONE
iawia002 commented 3 years ago

/lgtm

caicloud-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iawia002

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/caicloud/nirvana/blob/master/OWNERS)~~ [iawia002] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment