URL Highlighting is one character off the the left

caidongyun / futty

Automatically exported from code.google.com/p/futty

Other

0 stars 1 forks source link

URL Highlighting is one character off the the left #18

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Open up irssi
2. Go to a channel with special characters in the topic
3. Underlining hyperlinks will not work properly

What is the expected output? What do you see instead?
I have a channel that has a topic like this: "JEE LAN MODE CONFIRMED!!! | 
（　｀ー´） ♥". That causes the all the links to be one character off 
to the left so the last letter is not parsed with URL. Irssi is also using 
UTF-8.

What version of the product are you using? On what operating system?
FuTTY: 2011-07-13:r47
irssi: irssi 0.8.15 (20100403 1617)
OS (server): Linux lakka 3.1.10-grbfs-kapsi
OS (desktop): Windows 7 64-bit

Please provide any additional information below.

Original issue reported on code.google.com by rik...@gmail.com on 24 Feb 2012 at 11:35

Attachments:

futty_url_bug.png

GoogleCodeExporter commented 8 years ago

I just updated FuTTY, and it's built with _UNICODE instead of _MBCS.
Tell me if that fixes the problem or not.

Original comment by FireEgl on 8 Jun 2012 at 6:25

Changed state: Accepted
Added labels: Usability

GoogleCodeExporter commented 8 years ago

Issue 17 has been merged into this issue.

Original comment by FireEgl on 8 Jun 2012 at 6:26

GoogleCodeExporter commented 8 years ago

Tried the new version. Problem is still the same.

Original comment by rik...@gmail.com on 8 Jun 2012 at 7:13

GoogleCodeExporter commented 8 years ago

I think URL detection will probably work in PuTTYCh if you want to use it 
instead.. 
It has its own Hyperlink implementation...

PuTTY Chinese Version - http://code.google.com/p/puttychs/
(delete putty.lng to make it display in English)

And as a note to coders, their Hyperlink implementation can be found in this 
diff..
https://raw.github.com/emonkak/putty/4880c62e3cde6931dc6cb6e663176dca0a2adae3/pa
tch/gdi-20120211.diff
It contains a crapload of other things too though..plus it's for the 0.62 
release of PuTTY, not the development (SVN) branch..which FuTTY is based on.
I'm not interested in trying to rip out the Hyperlink code from it myself, but 
if somebody else wants to I'll accept a patch.

Original comment by FireEgl on 11 Jun 2012 at 2:39

Added labels: Component-UI, OpSys-Windows

GoogleCodeExporter commented 8 years ago

Please check to see if this bug still applies to the current FuTTY release.

Original comment by FireEgl on 31 Aug 2013 at 7:13

Changed state: Unverified