search

caiiiycuk / js-dos

The best API for running dos programs in browser
https://js-dos.com
1.06k stars 125 forks source link

Bug: InitFS settings works only in case i don't set a URL #353

Open shaylevary opened 1 week ago

shaylevary commented 1 week ago

Hi,

Since i've mentioned this bug only in Discord, I thought that for the sake of good order, it should also appear on GitHub's issues, so you'll be able to fix it when you can.

Currently when i try to set initFS, it doesn't work or create files "on the fly" - ONLY if i set "dosboxconf", without a url, it works ok.

This means that when I set a URL file, the script completely ignores the initFs command and does not generate any of the files I've set.

I would appreciate it if you could please fix this bug so i can use the Initfs command when loading also URL files. I would also appreciate if you can pleae allow to set the layersConfig without any dependency on the dosboxconf command.

Thank you.

caiiiycuk commented 1 week ago

Initially it was by design, when you provide the url it means that you provide fully configured self contained archive. But I don't see any disadvantages to implement this.

shaylevary commented 1 week ago

Excellent, thank you very much.

I believe that this way it will be possible to define the virtual buttons dynamically without having to create them through the bundle everytime.

In addition, it would be nice if it can be also possible to define the dosboxconf in the same way dynamically through the api script, thus determining a different settings each time from the scripr code or set a different executable file each time without having to define them each time through the bundle.

Thank you for all your time and effort on this wonderful project ❤️