search

caikit / caikit-nlp

Apache License 2.0
12 stars 49 forks source link

deps: update peft to install from pypi #265

Closed anhuong closed 11 months ago

anhuong commented 1 year ago

relates to: #263

anhuong commented 1 year ago

I tested this by running the tox unit tests and by running the Getting_Started jupyter notebook which ran successfully through the training. I haven't worked with caikit-nlp too much, is there another way that this should be tested? Also, it looks like that on the next release tag it will trigger the pypi push - does this need to be tested?

gkumbhat commented 1 year ago

@anhuong thanks for fixing the package here @anhuong . We would need to do an end to end training test with this, to make sure the training goes through smoothly for seq2seq and causal-lm models and also we are able to do inferencing on the tuned prompts. 🤔

dtrifiro commented 1 year ago

How about just pinning peft==0.6.0 and letting dependabot submit PRs for updates?

gkumbhat commented 1 year ago

@anhuong actually lets go with @dtrifiro 's idea of pinning PEFT. That would be a more resilient way of handling for this case.

evaline-ju commented 11 months ago

Verified training ability and inference after deployment (PT, MPT on causal lm [bloom] and seq2seq [flan-t5-xl])

Edit: update after revert of HF trainer in 0.4.0 - I verified that results were consistent on inference for the same models across version changes