search

cainus / codecov.io

MIT License
44 stars 50 forks source link

if the token is not found, it should not have exit code 0 #26

Closed jonathanong closed 8 years ago

jonathanong commented 8 years ago

right now, it has an exit code of 0, so my tests do not fail. this might be intentional, but i prefer if it failed (at least if the server isn't down)

./node_modules/.bin/codecov
  _____          _  
 / ____|        | |  
| |     ___   __| | ___  ___ _____   __  
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /  
| |___| (_) | (_| |  __/ (_| (_) \ V /  
 \_____\___/ \__,_|\___|\___\___/ \_/  
                                v1.0.1
==> Detecting CI Provider
    Circle CI Detected
==> Configuration: 
    Endpoint: https://codecov.io
{ service: 'circleci',
  build: '145.0',
  job: '145.0',
  commit: '65dee33673219254c83ad6720f0b32a0f7845865',
  branch: 'codecov',
  pr: undefined,
  slug: 'jonathanong/server',
  package: 'node-v1.0.1' }
==> Building file structure
==> Generating gcov reports (skip via --disable=gcov)
    $ find . -type f -name '*.gcno'  -exec gcov  {} +
==> Scanning for reports
    + ./coverage/lcov.info
==> Uploading reports
    HTTP 400
Please provide the repository token to upload reports via `-t :repository-token`
stevepeak commented 8 years ago

Hey @jonathanong thank you for the feedback. I'll add this in the next hack :+1:

stevepeak commented 8 years ago

PS the project is actually: https://github.com/codecov/codecov-node

https://github.com/codecov/codecov-node/issues/7