search

cainus / codecov.io

MIT License
44 stars 50 forks source link

Add services #8

Closed stevepeak closed 9 years ago

stevepeak commented 9 years ago
stevepeak commented 9 years ago

@cainus can you help me fix the execSync. I'm not sure why is broken for node v0.11. Thanks

codecov-io commented 9 years ago

Current Coverage via 58f3114 is 60.36%

Merging add-services into master will change coverage by -1.12%

@@            master   add-services   diff @@
=============================================
  Files           14             13     -1
  Stmts          122            111    -11
  Branches        35             33     -2
=============================================
- Hit             75             67     -8
  Partial         20             20       
+ Missed          27             24     -3
cainus commented 9 years ago

Hey @stevepeak ! Sorry about the slowness... I've been busy as hell lately. You have contributor status if you want to merge this. I also thought you were going to fork this into a codecov.io repo (which is cool with me)? Also: I think I can transfer publisher status on the npm package to you as well. Let me know how you want to proceed.

stevepeak commented 9 years ago

@cainus thank you for responding. I understand the busy, I have been too as well.

I don't know how to fix the tests for Node v0.11 which is related to the bash commands got get the current branch and sha.

I'll be merging this towards the end of April. I have many improvements to Codecov coming out in 2 weeks or so. Partial Line Coverage for node is one of them.

Perhaps these next two weeks you could checkout what I've put together and give it a shot. Thanks!