ventralnet
commented
6 years ago Sounds good to me!
On Fri, Aug 24, 2018, 3:46 PM Caio Fernandes notifications@github.com wrote:
@caiofsouza commented on this pull request.
In README.md https://github.com/caiofsouza/vue-backtotop/pull/9#discussion_r212736084 :
@@ -43,6 +43,11 @@ components: { BackToTop } | bottom | String | 40px | bottom position of the component | | right | String | 30px | right position of the component |
+## Events + +| Name | Description | +|------------------------|--------------------------------------------------------------------------| +| triggered | Fired when back to top element is clicked |
Hey @ventralnet https://github.com/ventralnet, Thanks for the issue and the PR ;D
This feature is amazing!!
About the event name, what you think if we use scrolled and the description Fired when page's scroll end ?
In src/BackToTop.vue https://github.com/caiofsouza/vue-backtotop/pull/9#discussion_r212736366 :
@@ -65,6 +65,7 @@ export default {
- @return {void} */ backToTop () {
- this.$emit('triggered'); window.smoothscroll()
I think that is better to emit event after the window.smoothscroll()
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/caiofsouza/vue-backtotop/pull/9#pullrequestreview-149437223, or mute the thread https://github.com/notifications/unsubscribe-auth/AAp45fuAFnL9mixINf9X47BN3rd0EZTtks5uUFgbgaJpZM4WJyIf .
Closes #8