caiogondim / bullet-train.zsh

:bullettrain_side: An oh-my-zsh shell theme based on the Powerline Vim plugin
MIT License
2.82k stars 383 forks source link

Let's add some (basic) Elixir support #181

Closed vadviktor closed 7 years ago

dawikur commented 7 years ago

Lets wait a little bit for #188 and than we can ~remove~ not-add variable (this PR was first, but it will be just a noise to first add something just to remove it in next commit). Are you fine with it?

As a side note, what terminal/font are you using? On my Arch this new prefix is just a square (but the same applies to python prefix..).

vadviktor commented 7 years ago

Hey @dawikur I'm fine to hold off with this. The unicode I chose for Elixir is https://unicode-table.com/en/1F4A7/ (droplet). I mostly use Fira Code font in the terminal but even Droid and Dejavu prints it fine. Using Konsole as terminal btw.

Any more I can help?

dawikur commented 7 years ago

OK, #188 landed successfully. Can you rebase with proper changes?

vadviktor commented 7 years ago

@dawikur conflict resolved, ready to go :)

vadviktor commented 7 years ago

You are a true friend @dawikur :) I'll have a more thorough look bit later. Thanks for being sharp.

dawikur commented 7 years ago

I think it looks good. @caiogondim what do you think?

caiogondim commented 7 years ago

Looks good to me 😊