search

caiogondim / bullet-train.zsh

:bullettrain_side: An oh-my-zsh shell theme based on the Powerline Vim plugin
MIT License
2.82k stars 383 forks source link

close #186: Remove redundant *_SHOW* variables #188

Closed dawikur closed 7 years ago

dawikur commented 7 years ago

This commit removes all _SHOW variables for showing/hiding segments. Now Hg/Mercurial completely disappears - should I also remove (now empty) variable table from README?

Two remaining SHOWs are:

What about default BULLETTRAIN_PROMPT_ORDER variable? Should I change it to conform default _SHOWs? Or, as this is anyway quite invasive change, we can leave it by?

Any suggestions are welcome :smile:

dawikur commented 7 years ago

Is this fine? What do you think?

caiogondim commented 7 years ago

I like it. Makes the code simpler.

@vadviktor Thoughts about this?

vadviktor commented 7 years ago

This is a must have refactor. I for one found myself using only the ordering array to switch on/off features. Great PR!

dawikur commented 7 years ago

Great, merging.

caiogondim commented 7 years ago

Looks like we have a new major release with this 🎉