search

caiogondim / bullet-train.zsh

:bullettrain_side: An oh-my-zsh shell theme based on the Powerline Vim plugin
MIT License
2.82k stars 383 forks source link

Add support to remove particular elements from prompt in .zshrc #196

Closed elzoona closed 7 years ago

elzoona commented 7 years ago

If $ZSH is set outside the home dir (as in Archlinux's AUR package or to install once for multiple users) removing elements from the prompt requires root access. To avoid this I added a BULLETTRAIN_PROMPT_REMOVE option to remove several elements just editing the .zshrc in the home directory.

dawikur commented 7 years ago

Why simply not removing those items from BULLETTRAIN_PROMPT_ORDER? It is not intended to edid in place, but to specify your own BULLETTRAIN_PROMPT_ORDER in .zshrc, which is per user. Same as you would specify BULLETTRAIN_PROMPT_REMOVE.

elzoona commented 7 years ago

To avoid repeating the whole array to remove one element, but yes, maybe it wasn't a good idea!

dawikur commented 7 years ago

It looks like adding same capabilities but from other side. If you really need one base order and the ability for each user to customize it I would rather add it to your own setup, not to theme. @caiogondim What do you think?

caiogondim commented 7 years ago

Let's keep things simple. We are trying to build something that will last a long time. If we add it, we will have to support it forever. And there is already a way of doing this.

I, myself, am a big fan of the Zen of Python.

There should be one-- and preferably only one --obvious way to do it.

And we already have an obvious ay for doing it.

I vote for no.

elzoona commented 7 years ago

Reading the arguments it seems reasonable to have only one option (even if "duplicates" an array), and merging this would result in two (very) different ways to accomplish the same thing, something I even hate. I am closing this pull request now, but thanks for the consideration!