search

caiogondim / bullet-train.zsh

:bullettrain_side: An oh-my-zsh shell theme based on the Powerline Vim plugin
MIT License
2.82k stars 382 forks source link

Changed Go Versioning output to allow multiple segments #277

Closed hconrad closed 6 years ago

hconrad commented 6 years ago

Hello there,

Pardon if this is not the correct way to approach this. Yup this might be my first PR. Love the bullet-train theme. Today I started learning about go and noticed that there is an issue with multi segmented versions on the prompt output. It would look

1.1 0.10

and have a lot of white space. I think this new regex will work as long as the version number comes first.

Let me know if you want to discuss it's just a suggestion and appears to work with at least the current go version information.

hconrad commented 6 years ago

Thanks awk is definitely a nicer solution.

On Tue, Apr 24, 2018 at 3:35 AM, Salmanul Farzy notifications@github.com wrote:

264 https://github.com/caiogondim/bullet-train.zsh/pull/264

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/caiogondim/bullet-train.zsh/pull/277#issuecomment-383833466, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqUbiPEgCDedzQn-7DYA01AqY3pngl5ks5trtXKgaJpZM4Tg-CV .

embano1 commented 6 years ago

Hi,

I also submitted a PR until someone pointed me to another PR on this :) https://github.com/caiogondim/bullet-train.zsh/pull/264

hconrad commented 6 years ago

Indeed :) I shall abandon mine :)