caiogondim / bullet-train.zsh

:bullettrain_side: An oh-my-zsh shell theme based on the Powerline Vim plugin
MIT License
2.82k stars 382 forks source link

Go 1.10.x breaks version prompt layout #278

Closed spotlightishere closed 6 years ago

spotlightishere commented 6 years ago

The introduction of Go 1.10.x gave a second digit to the version number.

https://github.com/caiogondim/bullet-train.zsh/blob/06f1d86ae2a407cf24a833ee892e6f9c748283ff/bullet-train.zsh-theme#L539

only expects one digit as shown below, causing the prompt to newline:

> go version | grep --colour=never -oE '[[:digit:]].[[:digit:]]'
1.1
0.2
salmanulfarzy commented 6 years ago

Duplicate of #255, Fixed with #264

spotlightishere commented 6 years ago

Ah, thanks. I did a terrible search beforehand it seems.