caiogondim / bullet-train.zsh

:bullettrain_side: An oh-my-zsh shell theme based on the Powerline Vim plugin
MIT License
2.82k stars 382 forks source link

fix(kubernetes-context): added to default prompt order #290

Open Qwerios opened 5 years ago

Qwerios commented 5 years ago

As requested here: https://github.com/caiogondim/bullet-train.zsh/pull/257#issuecomment-415733705

Added it just after the aws prompt which seemed like the proper place

topagae commented 5 years ago

Sadly even when making this change I can't get the prompt to work. Saddening =(

Qwerios commented 5 years ago

Sadly even when making this change I can't get the prompt to work. Saddening =(

You still need to ensure the normal kubernetes configuration envs are set: https://github.com/caiogondim/bullet-train.zsh#kubernetes-context

And you can verify that kubectl config current-context actually returns a value.

topagae commented 5 years ago

I very certainly did. I ran through every line and it was all kosher. Set the env var. Tested it. Tested all the if statements. Tested the grep of the config. For whatever reason it just doesn't render the prompt. Very sad.

On Thu, Feb 21, 2019, 12:20 AM Mark Doeswijk notifications@github.com wrote:

Sadly even when making this change I can't get the prompt to work. Saddening =(

You still need to ensure the normal kubernetes configuration envs are set: https://github.com/caiogondim/bullet-train.zsh#kubernetes-context

And you can verify that kubectl config current-context actually returns a value.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/caiogondim/bullet-train.zsh/pull/290#issuecomment-465905010, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQLuaNnUtCO6vym1CkY69zxDi1WGU1gks5vPlbUgaJpZM4WMTuN .

drewgonzales360 commented 5 years ago

Hi I just ran into this. I can confirm it works :smile: Can we merge this or document it?

chris-lee-parsable commented 4 years ago

I had to dig through and find this at a new job a year later and it's still not merged, sad!