search

caiogondim / logdown.js

:pencil2: Debug utility with markdown support that runs on browser and server
http://caiogondim.github.io/logdown.js/
MIT License
1.02k stars 37 forks source link

Switch to eslint and prettier #99

Open SleepWalker opened 7 years ago

SleepWalker commented 7 years ago

Let's do that!

I'm not agree with the rules, that standard js dictates, but this is another story. The reason why I suggesting this is because eslint + prettier will produce match more better dev experience. Standardjs has a slogan 'No decisions to make', but that is really not true.

If you look at standard docs or the code of logdown you will see eslint comments everywhere. So we are know exactly what decision was made and we are depending on that decision. According to this the standard lib has no sense. There is no encapsulation and moreover configs can not be completely avoided (e.g. ignore config), so in the end result standard is half-hearted solution (at least in the modern world). Better to use eslint directly (we can set up exactly the same rules). It will provide better IDE integration, because everyone has eslint extension installed. Another one good thing is that we will be able to remove /* eslint-env jest */ comments and use eslint overrides instead.

Additionally we can add precommit hooks, that will ensure, that we are commiting linted and pushing tested code.

caiogondim commented 7 years ago

I don't have hard feelings regarding this. But I would rather work on smashing bugs, making the lib faster, making it more reliable :)

But if you feel in the mood of working on it, go for it 👍 I vote for merging.

stale[bot] commented 7 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bennycode commented 6 years ago

@lipis, do you have a Prettier template ready? This lib could need your help. 🙂

lipis commented 6 years ago

@bennyn here you go: #104 :)

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.