search

caioricciuti / ch-ui

Use CH-UI to work with your data from Click House self-hosted with a user-friendly interface. CH-UI is a modern and feature-rich user interface for ClickHouse databases. It offers an intuitive platform for querying ClickHouse databases, executing queries, and visualizing metrics about your instance.
https://ch-ui.caioricciuti.com
MIT License
117 stars 12 forks source link

feat: add some improvements for error #19

Closed thiagodsti closed 1 month ago

thiagodsti commented 1 month ago

I've changed a bit the pattern to handle error. Please let me know if you like this approach, I just changed the credentials.store as an example.

The files .store is better to not have toast. It's better to split the view to handle the interaction with the user (dialogs, toast, etc..) and the stores only to handle the communication with the backend and save data that must to be global (like the user when logged in).

So this PR I removed some console.errors and console.log, I removed the duplication of toasts, and I moved the toast logic to the view part.

This way it will be easier as well to make automated tests.

caioricciuti commented 1 month ago

I think it's awesome, I'm glad you had this idea, the implementation looks pretty and solid, thank you!