search

caipng / pe

0 stars 0 forks source link

Poor duplicate check for tags #5

Open caipng opened 2 years ago

caipng commented 2 years ago

Steps to reproduce

  1. With someone in index 1 and with no tags, enter the command tag 1 someTag
  2. Then enter tagall sometag or a similar command

Expected

The UG advertises : "Will not add duplicate tags to persons." Hence, the app should either display a warning or the command should run without adding a new tag.

Actual

The duplicate tag is added

Screenshot 2021-11-12 at 4.48.20 PM.png

nus-pe-bot commented 2 years ago

Team's Response

Thank you for your feedback, however, this is an intended feature of the app to add more customizability for tags.
For instance how important and IMPORTANT can convey different meanings and hence should not be considered duplicates of each other.
Yet if we have more tags which are exactly the same there should not be more of said tag attached to the person as such a duplicate is worth much less in terms of functionality.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi, I don't think that this bug is an intended feature, for the following reasons:

  1. The UG clearly states that duplicate tags should not be added.

Screenshot 2021-11-17 at 5.01.06 PM.png

Under the duplicate detection section in the UG, there is no information about tags. There is only this section on names which also states that capitalisation is disregarded when checking for duplicates.

Screenshot 2021-11-17 at 5.04.14 PM.png

If this was truly an intended feature as claimed, it has not been documented at all.

  1. The example of the tag important being different from IMPORTANT is rather contrived and doesn't reflect a more realistic use case.

Here are some example tags from your own documentations: programmer, friend, OS, CS2103T, CS2040, CS2030.

For every one of this example tags, the capitalisation clearly don't matter. The tag cs2040 and CS2040 has no semantic difference.

If I were trying to tag someone as a Programmer when he has already been tagged as a programmer, this should be prevented.

Case sensitivity for tags makes very little sense. Users would have to remember the exact capitalisations of all existing tags to make sure that he doesn't accidentally tag the same person twice.

  1. The app is buggy when such tags exist. (Tags that differ only by capitalisation)

As reported here, basic uses of tag commands fail when such tags exist. If this was indeed an intended feature and the team developed the app with this in mind, I believe such bugs would have surfaced long ago.

As such, I maintain that this is a FunctionalityBug of severity low. In fact, I may even argue that this is a medium severity bug as having slightly different capitalisation when typing in tags is not exactly "very rare" and this does bring about quite some inconvenience, given that basic tag commands fail when such tags exist. Regardless, I will just stick with my original severity.