search

caitp / karma-coveralls

A Karma plugin to upload coverage reports to coveralls.io
65 stars 13 forks source link

Major cleanup #32

Closed maxnordlund closed 8 years ago

maxnordlund commented 8 years ago

This cleans up the implementaion to make it more consistent with JavaScript and node coding standards.

caitp commented 8 years ago

Not a fan, sorry man

maxnordlund commented 8 years ago

Why is that? I found it really hard to read before, and this fixes that.

caitp commented 8 years ago

Some of the functional changes look possibly okay --- but I'd prefer them to be seperate from code style changes, which I would prefer not to accept --- the only style change should be making the style more consistent throughout the file (it is admittedly a bit inconsistent)