S3 - jt_getBlockTransactionCountByHash，如果hash过长，返回的结果没有result

foreso-GitHub commented 3 years ago

jt_getBlockTransactionCountByHash，如果hash过长，返回的结果没有result。版本：v0.5.4-dev-20210202-5f35ae627660de5fcdc558220580c07e9d760eb3 TestCase：FCJT_getBlockTransactionCountByHash_000020

{
    "jsonrpc": "2.0",
    "method": "jt_getBlockTransactionCountByHash",
    "params": [
        {
            "hash": "B07647D61E6F7C4683E715004E2FB236D47DB64DF92F6504B71D6A1D4469530A1F"
        }
    ],
    "id": 1
}

{
    "error": {
        "desc": "Unexpected program state.",
        "info": "runtime error: index out of range"
    },
    "id": 1,
    "jsonrpc": "2.0",
    "status": -189,
    "type": "tefEXCEPTION"
}

caivega commented 3 years ago

已经修复，下一个build验证

foreso-GitHub commented 3 years ago

在版本v0.5.4-dev-20210202-95e57512b464d7595068a4dda3e2fe1cfae85d1b验证，已经修正。

foreso-GitHub commented 3 years ago

如下请求，包括jt_getBlockTransactionCountByNumber，仍然会导致返回的结果没有result。

{
    "jsonrpc": "2.0",
    "method": "jt_getBlockTransactionCountByHash",
    "params": [
        {
            "hash": "B07647D61E6F7C4683E715004E2FB236D47DB64DF92F6504B71D6A1D4469530A",
            "ledger": "current"
        }
    ],
    "id": 1
}

{
    "error": {
        "desc": "Unexpected program state.",
        "info": "runtime error: invalid memory address or nil pointer dereference"
    },
    "id": 1,
    "jsonrpc": "2.0",
    "status": -189,
    "type": "tefEXCEPTION"
}

{
    "jsonrpc": "2.0",
    "method": "jt_getBlockTransactionCountByNumber",
    "params": [
        {
            "number": "999999999",
            "ledger": "current"
        }
    ],
    "id": 1
}

{
    "error": {
        "desc": "Unexpected program state.",
        "info": "runtime error: invalid memory address or nil pointer dereference"
    },
    "id": 1,
    "jsonrpc": "2.0",
    "status": -189,
    "type": "tefEXCEPTION"
}

{
    "jsonrpc": "2.0",
    "method": "jt_getBlockTransactionCountByNumber",
    "params": [
        {
            "number": "-100",
            "ledger": "current"
        }
    ],
    "id": 1
}

{
    "jsonrpc": "2.0",
    "method": "jt_getBlockTransactionCountByNumber",
    "params": [
        {
            "number": "addeew",
            "ledger": "current"
        }
    ],
    "id": 1
}

caivega commented 3 years ago

已经修复，同时加强了block number的错误辨识度，针对不正确的block number, 返回相应的错误信息，可以在下一个build验证

foreso-GitHub commented 3 years ago

在版本v0.5.4-dev-20210204-37b2e5247195c3f892ba503d112b74f3d75a7631中验证，已经修复。

caivega / ipfslib

S3 - jt_getBlockTransactionCountByHash，如果hash过长，返回的结果没有result #177