caivega / ipfslib

Other
2 stars 1 forks source link

S3 - 同样的错误,在ledger==current和ledger==validated时,返回的错误info不一致 #179

Closed foreso-GitHub closed 3 years ago

foreso-GitHub commented 3 years ago

同样的错误,在ledger==current和ledger==validated时,返回的错误info不一致。 版本:v0.5.4-dev-20210202-95e57512b464d7595068a4dda3e2fe1cfae85d1b TestCase:FCJT_getTransactionByHash_000040

比如,参数中一样的hash,ledger==validated返回can't find transaction,ledger==current返回no such transaction:

{
    "jsonrpc": "2.0",
    "method": "jt_getTransactionByHash",
    "params": [
        {
            "hash": "B07647D61E6F7C4683E715004E2FB236D47DB64DF92F6504B71D6A1D4469530A",
            "ledger":"validated"
        },
        {
            "hash": "B07647D61E6F7C4683E715004E2FB236D47DB64DF92F6504B71D6A1D4469530A",
            "ledger":"current"
        }
    ],
    "id": 1
}

{
    "error": {
        "count": 2,
        "desc": "The compound error.",
        "info": "2 errors"
    },
    "id": 1,
    "jsonrpc": "2.0",
    "result": [
        {
            "error": {
                "desc": "No matching entry found.",
                "info": "can't find transaction B07647D61E6F7C4683E715004E2FB236D47DB64DF92F6504B71D6A1D4469530A"
            },
            "status": 140,
            "type": "tecNO_ENTRY"
        },
        {
            "error": {
                "desc": "No matching entry found.",
                "info": "no such transaction: B07647D61E6F7C4683E715004E2FB236D47DB64DF92F6504B71D6A1D4469530A, current"
            },
            "status": 140,
            "type": "tecNO_ENTRY"
        }
    ],
    "status": 1000,
    "type": "tedCOMPOUND"
}
caivega commented 3 years ago

类似不存在的信息,统一成,can't find XXX 还是 no such XXX,还是其他信息,大家有没有更好的说法,我统一改下,如果大家都没意见,我就用第一个,can't find XXX

foreso-GitHub commented 3 years ago

类似不存在的信息,统一成,can't find XXX 还是 no such XXX,还是其他信息,大家有没有更好的说法,我统一改下,如果大家都没意见,我就用第一个,can't find XXX

同意can't find XXX

caivega commented 3 years ago

已经改成,can't find XXX,而且现在所有类似的错误信息都集中到一个函数了,改起来也方便,后续大家如果有更好的信息表达,我这边改下就行,比较方便

foreso-GitHub commented 3 years ago

在版本v0.5.4-dev-20210204-37b2e5247195c3f892ba503d112b74f3d75a7631中验证,已经修复。