Closed Binlogo closed 4 years ago
Hi @Binlogo, the changes look great to me. I have the same idea with you that I prefer making no transforms as well. Neat!
I have an app on the App Store running with IceCream for a while now, and my primary keys already had non ASCII characters. Now I tried upgrading to IceCream's latest version and it crashes when trying to sync because primary keys can't contain ASCII characters anymore. However, they're already on iCloud with those keys! So this change will basically make it unusable to previous users.
Add assertions for issue #190
I've considered checking validation and transform to a valid name if need.
But I think it's better for user to decide how to handle this issue. By the way, just make assertions won't have any other side effect or migration issue.