search

cajames / kirby-editor-gallery-block

A gallery block for the Kirby Editor
MIT License
61 stars 5 forks source link

fix: Fix German Translation #12

Closed medienbaecker closed 4 years ago

medienbaecker commented 4 years ago

This pull request contains fixes for the new variables you added. I'm not 100% sure about the editor.blocks.gallery.settings.group.label and just translated it to "group name". In the context of a gallery this might be clearer.

cajames commented 4 years ago

Awesome thanks for that!

The group label is a bit tricky, I'm considering removing it entirely. It's actually used for drag groups, to limit which rows an image can be dragged into. But seeing as the user is in control I think it makes sense just to default it (which is what happens right now). I might do a PR to remove that setting, it would confuse users.