search

cajames / kirby-editor-gallery-block

A gallery block for the Kirby Editor
MIT License
61 stars 5 forks source link

Error with loader.png #21

Open mynameisfreedom opened 4 years ago

mynameisfreedom commented 4 years ago

Hi @cajames !

I am experiencing an error with loader.png

loader-error

Can you reproduce the issue?

cajames commented 4 years ago

Hey @mynameisfreedom! Oh, that's interesting. Though I haven't released any updates and it used to work before right?

Did you upgrade your version of Kirby or the Editor? What version are you using?

I just tested it on Kirby 3.3.6, with the editor (probably not the latest version), and it seem to work fine.

cajames commented 4 years ago

I've also just tested it on the latest Kirby 3.4.2, with the latest Editor 1.0.4, and it seems to work fine. Could you please let me know what versions you're using?

mynameisfreedom commented 4 years ago

Hi, @cajames sorry for the delay.

It is happening from the beginning, I just didn't see it though. I am using all the latest versions, and Kirby, and your Gallery block.

But, as you can see from the screenshot, issue happens when Kirby website installation is in the subfolder.

Add install to the subfolder and test.

zufallswerk commented 4 years ago

I had the same problem. For compatibility reasons I had to change the Kirby folder from "media" to "resources". No problem with Kirby and Kirby Editor.

The image "loader.png" is not found under /media/plugins/... @mynameisfreedom: you use a sub folder. the file is under /zero-one/media/plugin/...

https://github.com/cajames/kirby-editor-gallery-block/blob/ef56d8695a1f66765d0d9142db075dde6368a024/src/components/Gallery.vue#L51

My simple solution https://github.com/zufallswerk/kirby-gallery/commit/22f0d652d592a43b8651ab872aca3b545f3c9c6c was to change the URL in the plugin. But this is not a good solution. But I have no other one at the moment.