cake-build / bakery

Cake server for code generation and script analysis
https://cakebuild.net/
MIT License
29 stars 14 forks source link

System.NotSupportedException: Cake does not support /v2/gotodefinition #137

Closed nils-a closed 2 years ago

nils-a commented 3 years ago

I noticed GoToDefinition is no longer working. the log shows:

[dbug]: OmniSharp.Stdio.Host
        ************ Request ************
{
  "Type": "request",
  "Seq": 42,
  "Command": "/v2/gotodefinition",
  "Arguments": {
    "FileName": "d:\\_dev\\test\\Nils.Cake",
    "Line": 7,
    "Column": 23,
    "WantMetadata": true
  }
}
[fail]: OmniSharp.Stdio.Host
        ************  Response (0.5418ms) ************ 
{
  "Request_seq": 42,
  "Command": "/v2/gotodefinition",
  "Running": true,
  "Success": false,
  "Message": "\"System.NotSupportedException: Cake does not support /v2/gotodefinition\\r\\n   at OmniSharp.Endpoint.EndpointHandler`2.<HandleRequestForLanguage>d__20.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Host\\\\Endpoint\\\\EndpointHandler.cs:line 233\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n   at OmniSharp.Endpoint.EndpointHandler`2.<Process>d__16.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Host\\\\Endpoint\\\\EndpointHandler.cs:line 131\\r\\n--- End of stack trace from previous location where exception was thrown ---\\r\\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\\r\\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\\r\\n   at OmniSharp.Stdio.Host.<HandleRequest>d__14.MoveNext() in D:\\\\a\\\\1\\\\s\\\\src\\\\OmniSharp.Stdio\\\\Host.cs:line 218\"",
  "Body": null,
  "Seq": 666,
  "Type": "response"
}

I'm guessing this came with https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.13

nils-a commented 3 years ago

I'm guessing this issue does not belong here, but rather in OmniSharp/omnisharp-roslyn. Actually I'm guessing it's a regression from https://github.com/OmniSharp/omnisharp-roslyn/pull/2168 : I think OmniSharp.Cake/**/GotoDefinitionHandler.cs should have been modified as well in that PR.

nils-a commented 2 years ago

https://github.com/OmniSharp/omnisharp-roslyn/pull/2212 has been merged. Now, the only thing missing is a new version of O#. 🎉

nils-a commented 2 years ago

This has been fixed, as of https://github.com/OmniSharp/omnisharp-roslyn/releases/tag/v1.37.17