Closed devlead closed 5 years ago
@devlead Thank you for implementing this!
The Windows-related changes I can pretty much merge as-is; as for the cake-version
implementation, I do have a bit of feedback on that.
Would you mind submitting 8205ae6 97dfdfa and 4dad707 448b24a as two separate PRs?
@ecampidoglio sure I can do that and then rebase this PR once 8205ae6 97dfdfa is in.
@ecampidoglio #4 submitted with 8205ae6 97dfdfa
@ecampidoglio PR rebased against latest master.
@ecampidoglio so I've redone most if this PR
installLocalCakeTool
to a more .NET tool generic approach in installLocalTool
.
This PR addresses #1, by adding support for specifying / pinning the version of Cake installed using
cake-version
property, example:This PR adds a bit more, please let me know if you want separate PRs/more focused PR, have separated in multiple commits though.
Adjusted tests to support Windows path if running on WindowsExecute tests on both Windows and LinuxBuild addin for integration tests (otherwise previous built version is used)cake-version
Only do coveralls if not PR i.e. running on master branch (build fails on PR / forks otherwise)