cake-build / cake-action

:cake::octocat: Run Cake (C# Make) scripts in your GitHub Actions workflows.
https://cakebuild.net
MIT License
45 stars 13 forks source link

GH1: Add option to specify version #2

Closed devlead closed 5 years ago

devlead commented 5 years ago

This PR addresses #1, by adding support for specifying / pinning the version of Cake installed using cake-version property, example:

    uses: ecampidoglio/cake-action@master
    with:
      cake-version: 0.34.1
      target: Version-Check-Task

This PR adds a bit more, please let me know if you want separate PRs/more focused PR, have separated in multiple commits though.

ecampidoglio commented 5 years ago

@devlead Thank you for implementing this!

The Windows-related changes I can pretty much merge as-is; as for the cake-version implementation, I do have a bit of feedback on that.

Would you mind submitting 8205ae6 97dfdfa and 4dad707 448b24a as two separate PRs?

devlead commented 5 years ago

@ecampidoglio sure I can do that and then rebase this PR once 8205ae6 97dfdfa is in.

devlead commented 5 years ago

@ecampidoglio #4 submitted with 8205ae6 97dfdfa

devlead commented 5 years ago

@ecampidoglio PR rebased against latest master.

devlead commented 5 years ago

@ecampidoglio so I've redone most if this PR