Closed devlead closed 3 years ago
@devlead isn't it kind of counter-intuitive to have mutually exclusive options cake-tool-manifest
and cake-version
?
What do you think of modifying the current cake-version
property:
add for consistency:
# equivalent to the current default when cake-version is omitted
# always uses the latest version
cake-version: latest
add instead of cake-tool-manifest
# use version from manifest
cake-version: tool-manifest # or manifest, from-manifest, something like that
This could then, given some time, become the new default if cake-version
is omitted.
Also, documentation of the new feature is still missing.
@nils-a makes total sense, adjusted to cake-version
parameter supporting tool-manifest
steps:
- name: Run the Cake script
uses: cake-build/cake-action@v1
with:
cake-version: tool-manifest
@ecampidoglio I've turned CakeVersion into a union type and incorporated your suggestions.
I tested it - I love it 👍
Thank you for your contribution! 🎉
Thank you for your contribution! 🎉
Excellent 👍, can't wait for a release to take this for a spin 😎
@devlead You can try it right now by referencing master
in your workflow:
uses: cake-build/cake-action@master
@devlead You can try it right now by referencing
master
in your workflow:uses: cake-build/cake-action@master
That actually I knew :) I used my fork before merged and tried master after. But have a few repos to PR and those have policies of pinning versions.