cake-build / cake-action

:cake::octocat: Run Cake (C# Make) scripts in your GitHub Actions workflows.
https://cakebuild.net
MIT License
45 stars 13 forks source link

GH26: Add support for installing Cake using tool manifest #27

Closed devlead closed 3 years ago

devlead commented 3 years ago
nils-a commented 3 years ago

@devlead isn't it kind of counter-intuitive to have mutually exclusive options cake-tool-manifest and cake-version?

What do you think of modifying the current cake-version property:

nils-a commented 3 years ago

Also, documentation of the new feature is still missing.

devlead commented 3 years ago

@nils-a makes total sense, adjusted to cake-version parameter supporting tool-manifest

steps:
  - name: Run the Cake script
    uses: cake-build/cake-action@v1
    with:
      cake-version: tool-manifest
devlead commented 3 years ago

@ecampidoglio I've turned CakeVersion into a union type and incorporated your suggestions.

nils-a commented 3 years ago

I tested it - I love it 👍

ecampidoglio commented 3 years ago

Thank you for your contribution! 🎉

devlead commented 3 years ago

Thank you for your contribution! 🎉

Excellent 👍, can't wait for a release to take this for a spin 😎

ecampidoglio commented 3 years ago

@devlead You can try it right now by referencing master in your workflow:

uses: cake-build/cake-action@master
devlead commented 3 years ago

@devlead You can try it right now by referencing master in your workflow:

uses: cake-build/cake-action@master

That actually I knew :) I used my fork before merged and tried master after. But have a few repos to PR and those have policies of pinning versions.