search

cake-build / cake-vs

Cake Extension for Visual Studio
https://marketplace.visualstudio.com/items?itemName=vs-publisher-1392591.CakeforVisualStudio
MIT License
67 stars 25 forks source link

(GH-18) Improvements to CI build scripts #48

Closed agc93 closed 7 years ago

agc93 commented 7 years ago

Was just wondering why I hadn't got any feedback on the PR we discussed @gep13 , but turns out I never raised it :confounded:

This is all pretty experimental stuff so let me know what you think before we either a) merge to develop and start the trial and error or b) temporarily change the ShouldPublishToMyGet condition to start building PRs as well (to build and package this one) and trial and error it that way.

Thoughts/comments etc?

gep13 commented 7 years ago

Building PR's won't work, as the required secure environment variables won't be hydrated during the build.

I would suggest just going for it 😄

agc93 commented 7 years ago

So everything looks at least vaguely correct to you @gep13 ?

gep13 commented 7 years ago

@agc93 enough that I would be happy to take it for a spin, yes 👍

agc93 commented 7 years ago

Let the trial and error experiments begin 😅