search

cake-build / cake-vs

Cake Extension for Visual Studio
https://marketplace.visualstudio.com/items?itemName=vs-publisher-1392591.CakeforVisualStudio
MIT License
67 stars 25 forks source link

(GH-52) Rework regex to allow whitespace #51

Closed nalla closed 7 years ago

nalla commented 7 years ago

Some projects may enforce special coding style guidelines on their projects. To be more flexible in this area the new regex will now allow whitespace before and in between the brackets. Following some examples of allowed task name definitions.

Task("F_0$0")
Task( "F_0$0" )
Task ( "F_0$0" )
Task ( "F_0$0" )
Task(
  "F_0$0"
)
Task (
  "F_0$0"
)
Task (
    "F_0$0"
)

@agc93 can you check if this will break you requirements?

agc93 commented 7 years ago

Hi @nalla and thanks for your contribution!

It looks like you haven't created an issue for this? Could you have a read through our contribution guidelines and then create an issue for this bug so that we can track it properly?

In the meantime, I will have a quick check over this change as well 👍

agc93 commented 7 years ago

Thanks again @nalla! This has been merged in and will be included in the next release of the extension.