search

cake-build / cake-vs

Cake Extension for Visual Studio
https://marketplace.visualstudio.com/items?itemName=vs-publisher-1392591.CakeforVisualStudio
MIT License
67 stars 25 forks source link

Added configuration section for tool settings with `CakePath` option #89

Closed MichaelSL closed 5 years ago

MichaelSL commented 6 years ago

I've decided to use the cake.config for settings.

79

agc93 commented 5 years ago

Thanks for your contribution @MichaelSL !

As I mentioned in my latest comment in #79 , we've added a new more robust method of locating cake.exe that also leverages cake.config to locate Cake.

I notice you specifically used a new cake.config key for this PR: ToolSettings.CakePath

Is having this extension locate cake.exe from a path different from the "usual" Cake tools path something you would need or just added because there weren't any better methods?

We'd love to get your feedback to make sure the new solution covers as many cases as possible!

MichaelSL commented 5 years ago

Hi @agc93 !

I've tried to add Cake to the legacy project with really strange folder layout. Making custom cake.exe path available for Visual Studio tools was one of the requirements.

The code you've merged into develop branch covers our use case. I think this merge request could be closed now.

agc93 commented 5 years ago

Great to hear @MichaelSL ! I'll close this PR now.

Hopefully, I'll actually be improving the path resolution/location behaviour a bit more before we publish 0.3.0 so happy to hear we're covering your use case.