search

cake-build / cake

:cake: Cake (C# Make) is a cross platform build automation system.
https://cakebuild.net
MIT License
3.91k stars 730 forks source link

GH2953: Feature addition target initializer msbuildsettings #3954

Closed FrankRay78 closed 2 years ago

FrankRay78 commented 2 years ago

Regarding the following (incomplete) PR which is now over 6 months old, https://github.com/cake-build/cake/pull/3721, I have rebased @sbwaggoner's original changes on to an up-to-date develop branch and made the change recommended by @devlead on 15 December 2021 during the PR review. Several unit tests have also been added to increase the code coverage of this area too.

Regarding the conditional StringSplitOptions approach recommended in the review, I tried implementing it as suggested but given .Net Core 3.1 StringSplitOptions enum doesn't include the StringSplitOptions.TrimEntries option, trimming still needed to be implemented manually in the code for that target framework. So the conditional compile logic didn't end up offering any benefit imho.

devlead commented 2 years ago

@FrankRay78 & @sbwaggoner your changes have been merged, thanks for your contributions 👍