Call multiple tasks from CLI in Frosting

cake-build / cake

:cake: Cake (C# Make) is a cross platform build automation system.

https://cakebuild.net

MIT License

3.85k stars 724 forks source link

Call multiple tasks from CLI in Frosting #4122

Closed juwens closed 1 year ago

juwens commented 1 year ago

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched issues to ensure it has not already been reported

Cake runner

Cake Frosting

Cake version

3.0.0

Operating system

Linux, Windows, macOS

Operating system architecture

64-Bit

CI Server

No response

What are you seeing?

Feature introduced with issue #2470 and PR #4054 was not implemented for frosting.

when i do build.ps1 --target=A --target=B only B gets executed.

What is expected?

A and B are executed

Steps to Reproduce

build.ps1 --target=A --target=B

Output log

No response

juwens commented 1 year ago

@devlead @FrankRay78

FrankRay78 commented 1 year ago

Thank you for this PR @juwens , my bad in that I didn't also include it in Frosting. My PR was done early on in my FOSS career and I didn't know the cake codebase well enough. The omission also wasn't picked up on review.

juwens commented 1 year ago

hey @FrankRay78, no need to excuse. That you contributed a cool feature (several people were looking for) to a FOSS project is awesome. 🙂
I, for example, do it way too rarely.
Oversight happen to everyone, no matter if junior or senior developer. Especially in complicated scenarios like cake, where two cli "frontends" exist for one core logic.
I'm not sure either if my PR is technically correct. It's more of a: basis for discussion.
I guess i'm in your position now ^^

augustoproiete commented 1 year ago

Resolved by https://github.com/cake-build/cake/pull/4123

cake-build-bot commented 1 year ago

:tada: This issue has been resolved in version v3.1.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: